harden booter reliability lanes and enforce flake/CI gates

Execute the reliability/flake hardening run across booter shell-adjacent suites,
focusing on deterministic assertions, unskipped first-party reliability tests,
repeat-run flake detection, and release/CI gate enforcement.

- Unskip and stabilize first-party reliability suites:
  - `packages/bare-os-booter/test.bare-os-www.js`
  - `packages/bare-os-booter/test.bare-os-ssh-holesail.js`
  - convert previously skipped coverage into active deterministic checks
  - add lifecycle hook stubs in suite test context for managed runtime paths
  - reduce network/port race sensitivity by shifting fragile HTTP-bound checks
    toward deterministic service/config/state validation where needed

- Replace weak reliability assertions in booter shell tests:
  - remove broad `t.ok(true)`-style pass-through checks
  - strengthen checks around here-doc/script mode and `sh -c` paths in
    `packages/bare-os-booter/test.js` with explicit exit/error constraints

- Add reliability hard-gate automation:
  - `scripts/verify-reliability-gates.mjs`
  - fail when `test.skip` exists in first
This commit is contained in:
Raven Scott
2026-04-26 23:39:07 -04:00
parent e2b721d19f
commit 04b3a96dfb
11 changed files with 182 additions and 94 deletions
+35
View File
@@ -0,0 +1,35 @@
#!/usr/bin/env node
import { readFile } from 'node:fs/promises'
import path from 'node:path'
const root = process.cwd()
const mustNoSkip = [
'packages/bare-os-booter/test.bare-os-www.js',
'packages/bare-os-booter/test.bare-os-ssh-holesail.js'
]
const mustNoWeak = [
'packages/bare-os-booter/test.js',
'packages/bare-os-booter/test.bare-os-www.js',
'packages/bare-os-booter/test.bare-os-ssh-holesail.js'
]
let bad = 0
for (const rel of mustNoSkip) {
const p = path.join(root, rel)
const txt = await readFile(p, 'utf8')
if (/\btest\.skip\(/.test(txt)) {
console.error(`${rel}: contains test.skip`)
bad++
}
}
for (const rel of mustNoWeak) {
const p = path.join(root, rel)
const txt = await readFile(p, 'utf8')
if (/t\.ok\(true\)/.test(txt)) {
console.error(`${rel}: contains t.ok(true)`)
bad++
}
}
if (bad > 0) process.exit(1)
console.log('verify-reliability-gates: ok')