snxraven/ravenbotv14
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Code Optimization for all files

Browse Source
This commit is contained in:
Raven Scott
2023-01-08 09:50:40 +02:00
parent cb8a312d93
commit 85f2d8d04a
10 changed files with 322 additions and 382 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
commands/general/joke.js
View File

@ -1,43 +1,31 @@
const {
EmbedBuilder
} = require('discord.js');
var giveMeAJoke = require('give-me-a-joke');
const { EmbedBuilder } = require('discord.js');
const giveMeAJoke = require('give-me-a-joke');
module.exports = {
name: "joke",
description: "Gets a funny joke",
run: async (client, interaction) => {
giveMeAJoke.getRandomDadJoke(function (joke) {
async run(client, interaction) {
let joke = await giveMeAJoke.getRandomDadJoke();
if (joke.includes("?")){
let jokeData = joke.split("?")
const embed = new EmbedBuilder()
.setColor("#FF0000")
.setTitle("Here is your joke...")
.setDescription(jokeData[0] + "?||" + jokeData[1] + "||")
.setTimestamp()
.setFooter({
text: `Requested by ${interaction.user.tag}`,
iconURL: `${interaction.user.displayAvatarURL()}`
});
interaction.editReply({
embeds: [embed]
});
} else {
const embed = new EmbedBuilder()
.setColor("#FF0000")
.setTitle("Here is your joke...")
.setDescription(joke)
.setTimestamp()
.setFooter({
text: `Requested by ${interaction.user.tag}`,
iconURL: `${interaction.user.displayAvatarURL()}`
});
interaction.editReply({
embeds: [embed]
});
}
})
if (joke.includes("?")){
let jokeData = joke.split("?");
joke = `${jokeData[0]}?||${jokeData[1]}||`;
}
const embed = createJokeEmbed(joke, interaction.user);
interaction.editReply({ embeds: [embed] });
},
};
};
function createJokeEmbed(joke, user) {
return new EmbedBuilder()
.setColor("#FF0000")
.setTitle("Here is your joke...")
.setDescription(joke)
.setTimestamp()
.setFooter({
text: `Requested by ${user.tag}`,
iconURL: user.displayAvatarURL()
});
}

67
commands/general/urban.js
View File

@ -1,47 +1,40 @@
const {
EmbedBuilder
} = require('discord.js');
var urban = require('urban')
const isNotDefined = require("is-not-defined");
const { EmbedBuilder } = require('discord.js');
const urban = require('urban');
module.exports = {
name: "urban",
description: "Searches Urban Dictionary",
options: [{
"name": "query",
"description": "The thing you want to search for",
"required": true,
"type": 3 // 6 is type USER
name: "query",
description: "The thing you want to search for",
required: true,
type: 3 // 6 is type USER
}],
run: async (client, interaction) => {
async run(client, interaction) {
let searchWord = interaction.options._hoistedOptions[0].value;
let search = urban(searchWord);
let searchWord = interaction.options._hoistedOptions[0].value
search = urban(searchWord);
let data = await search.first();
search.first(function(data) {
if (!isNotDefined(data)) {
const embed = new EmbedBuilder()
.setColor("#FF0000")
.setTitle("Results for: " + searchWord)
.setDescription("Definition: " + data.definition)
.addFields({
name: 'Example',
value: data.example
})
.setTimestamp()
.setFooter({
text: `Requested by ${interaction.user.tag}`,
iconURL: `${interaction.user.displayAvatarURL()}`
});
interaction.editReply({
embeds: [embed]
});
} else {
return interaction.editReply("Sorry, no results were found!")
}
});
if (data) {
const embed = createUrbanEmbed(data, searchWord, interaction.user);
interaction.editReply({ embeds: [embed] });
} else {
interaction.editReply("Sorry, no results were found!");
}
},
};
};
function createUrbanEmbed(data, searchWord, user) {
return new EmbedBuilder()
.setColor("#FF0000")
.setTitle(`Results for: ${searchWord}`)
.setDescription(`Definition: ${data.definition}`)
.addFields({ name: 'Example', value: data.example })
.setTimestamp()
.setFooter({
text: `Requested by ${user.tag}`,
iconURL: user.displayAvatarURL()
});
}