feat: error handling in POST /worlds/{id} and POST /worlds/{wId}/slot/{sId}

This commit is contained in:
CyberL1 2024-06-11 17:45:00 +02:00
parent 26fa8813dd
commit a6b70a0686
2 changed files with 103 additions and 4 deletions

View File

@ -324,8 +324,30 @@ namespace Minecraft_Realms_Emulator.Modes.External
[HttpPost("{wId}")] [HttpPost("{wId}")]
[CheckForWorld] [CheckForWorld]
[CheckRealmOwner] [CheckRealmOwner]
public async Task<ActionResult<bool>> UpdateWorld(int wId, WorldCreateRequest body) public async Task<ActionResult<(bool, ErrorResponse)>> UpdateWorld(int wId, WorldCreateRequest body)
{ {
if (body.Name.Length > 32)
{
ErrorResponse errorResponse = new()
{
ErrorCode = 400,
ErrorMsg = "World name cannot exceed 32 characters"
};
return BadRequest(errorResponse);
}
if (body.Description.Length > 32)
{
ErrorResponse errorResponse = new()
{
ErrorCode = 400,
ErrorMsg = "World description cannot exceed 32 characters"
};
return BadRequest(errorResponse);
}
var worlds = await _context.Worlds.ToListAsync(); var worlds = await _context.Worlds.ToListAsync();
var world = worlds.Find(w => w.Id == wId); var world = worlds.Find(w => w.Id == wId);
@ -341,8 +363,19 @@ namespace Minecraft_Realms_Emulator.Modes.External
[HttpPost("{wId}/slot/{sId}")] [HttpPost("{wId}/slot/{sId}")]
[CheckForWorld] [CheckForWorld]
[CheckRealmOwner] [CheckRealmOwner]
public async Task<ActionResult<bool>> UpdateSlotAsync(int wId, int sId, SlotOptionsRequest body) public async Task<ActionResult<(bool, ErrorResponse)>> UpdateSlot(int wId, int sId, SlotOptionsRequest body)
{ {
if (body.SlotName.Length > 10)
{
ErrorResponse errorResponse = new()
{
ErrorCode = 400,
ErrorMsg = "Slot name cannot exceed 10 characters"
};
return BadRequest(errorResponse);
}
var slots = await _context.Slots.Where(s => s.World.Id == wId).ToListAsync(); var slots = await _context.Slots.Where(s => s.World.Id == wId).ToListAsync();
var slot = slots.Find(s => s.SlotId == sId); var slot = slots.Find(s => s.SlotId == sId);

View File

@ -347,8 +347,30 @@ namespace Minecraft_Realms_Emulator.Modes.Realms.Controllers
[CheckForWorld] [CheckForWorld]
[CheckRealmOwner] [CheckRealmOwner]
[CheckActiveSubscription] [CheckActiveSubscription]
public async Task<ActionResult<bool>> UpdateWorld(int wId, WorldCreateRequest body) public async Task<ActionResult<(bool, ErrorResponse)>> UpdateWorld(int wId, WorldCreateRequest body)
{ {
if (body.Name.Length > 32)
{
ErrorResponse errorResponse = new()
{
ErrorCode = 400,
ErrorMsg = "World name cannot exceed 32 characters"
};
return BadRequest(errorResponse);
}
if (body.Description.Length > 32)
{
ErrorResponse errorResponse = new()
{
ErrorCode = 400,
ErrorMsg = "World description cannot exceed 32 characters"
};
return BadRequest(errorResponse);
}
var worlds = await _context.Worlds.ToListAsync(); var worlds = await _context.Worlds.ToListAsync();
var world = worlds.Find(w => w.Id == wId); var world = worlds.Find(w => w.Id == wId);
@ -365,8 +387,52 @@ namespace Minecraft_Realms_Emulator.Modes.Realms.Controllers
[CheckForWorld] [CheckForWorld]
[CheckRealmOwner] [CheckRealmOwner]
[CheckActiveSubscription] [CheckActiveSubscription]
public async Task<ActionResult<bool>> UpdateSlotAsync(int wId, int sId, SlotOptionsRequest body) public async Task<ActionResult<(bool, ErrorResponse)>> UpdateSlot(int wId, int sId, SlotOptionsRequest body)
{ {
if (body.SlotName.Length > 10)
{
ErrorResponse errorResponse = new()
{
ErrorCode = 400,
ErrorMsg = "Slot name cannot exceed 10 characters"
};
return BadRequest(errorResponse);
}
if (body.SpawnProtection < 0 || body.SpawnProtection > 16)
{
ErrorResponse errorResponse = new()
{
ErrorCode = 400,
ErrorMsg = "Spawn protection can only be between 0 and 16"
};
return BadRequest(errorResponse);
}
if (!new List<int>{ 0, 1, 2 }.Contains(body.GameMode))
{
ErrorResponse errorResponse = new()
{
ErrorCode = 400,
ErrorMsg = "Gamemode can only be one of 0, 1, 2"
};
return BadRequest(errorResponse);
}
if (!new List<int> { 0, 1, 2, 3 }.Contains(body.Difficulty))
{
ErrorResponse errorResponse = new()
{
ErrorCode = 400,
ErrorMsg = "Difficulty can only be one of 0, 1, 2, 3"
};
return BadRequest(errorResponse);
}
var slots = await _context.Slots.Where(s => s.World.Id == wId).ToListAsync(); var slots = await _context.Slots.Where(s => s.World.Id == wId).ToListAsync();
var slot = slots.Find(s => s.SlotId == sId); var slot = slots.Find(s => s.SlotId == sId);